#141680: "incorrect score display"
Apie ką šis pranešimas?
Kas nutiko? Pasirinkite iš žemiau esančio sąrašo
Kas nutiko? Pasirinkite iš žemiau esančio sąrašo
Patikrinkite, ar jau yra pranešimas apie tą patį dalyką
Jei taip, balsuokite už šią ataskaitą. Ataskaitos su dauguma balsų pateikiamos PRIORITETU!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Detalus apibūdinimas
-
• Jei ekrane matote kokį nors klaidos pranešimą, įklijuokite jį čia.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Prašome paaiškinti, ką norėjote padaryti, ką padarėte ir kas atsitiko
• Kokia tavo naršyklė?
opera
-
• Prašome nukopijuoti / įklijuoti tekstą, rodomą anglų kalba, o ne savo kalba. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here. Ar šis tekstas yra translation system? Jei taip, ar jis buvo išverstas daugiau nei 24 valandas?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kokia tavo naršyklė?
opera
-
• Prašome paaiškinti siūlomą pakeitimą tiksliai ir glaustai, kad būtų kuo lengviau suprasti, ką jūs siūlote.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kokia tavo naršyklė?
opera
-
• Kas buvo pavaizduota ekrane, tave užblokavus (juodas ekranas? Nepilna žaidimo sąsaja? Klaidos pranešimas?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kokia tavo naršyklė?
opera
-
• Į kurias taisykles neatsižvelgiama BGA žaidimo versijoje
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Ar taisyklių pažeidimas matomas žaidimo atkartojime? Jeigu taip, kuris veiksmo numeris?
• Kokia tavo naršyklė?
opera
-
• Kurį žaidimo veiksmą norėjai atlikti?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Ką reikia padaryti, kad iššauktum šį žaidimo veiksmą?
-
• Kas įvyko kai bandei tai padaryti (klaidos pranešimas, žaidimo būsenos pranešimas, ...)?
• Kokia tavo naršyklė?
opera
-
• Kuriuo žaidimo metu problema atsirado (koks buvo tuometinis žaidimo nurodymas)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Kas įvyko kai bandei atlikti žaidimo veiksmą (klaidos pranešimas, žaidimo būsenos pranešimas, ...)?
• Kokia tavo naršyklė?
opera
-
• Aprašykite rodomą problemą. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kokia tavo naršyklė?
opera
-
• Prašome nukopijuoti / įklijuoti tekstą, rodomą anglų kalba, o ne savo kalba. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here. Ar šis tekstas yra translation system? Jei taip, ar jis buvo išverstas daugiau nei 24 valandas?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kokia tavo naršyklė?
opera
-
• Prašome paaiškinti siūlomą pakeitimą tiksliai ir glaustai, kad būtų kuo lengviau suprasti, ką jūs siūlote.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kokia tavo naršyklė?
opera
Raportų istorija
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Papildyti šį raportą
- Kitas stalo ID / ėjimo ID
- Ar F5 išsprendė šią problemą?
- Ar problemos atsirado keletą kartų? Kiekvieną kartą? Atsitiktiniu metu?
- If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here.
